Show initial suggestions in rich text Link UI #57743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
requested review from
ellatrix,
fluiddot,
dcalhoun and
nerrad
as code owners
getdave
added
[Type] Enhancement
This comment was marked as resolved.
This comment was marked as resolved.
|
Size Change: +50 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
scruffian
approved these changes
Jan 11, 2024
getdave
commented
Jan 11, 2024
packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js
Outdated
Show resolved
Hide resolved
richtabor
previously requested changes
Jan 11, 2024
There was a problem hiding this comment.
Looking good.
Once the navigation link block variations suggestions is resolved, this is good to go.
Currently page suggestions are established as the most recent pages published on the site. I'm interested in perhaps exploring what a reverse order would feel like, with your site's first created pages surfaced highest in the suggestions (assuming that when the site was created, the most important pages were created first).
packages/core-data/src/fetch/__experimental-fetch-link-suggestions.js
Outdated
Show resolved
Hide resolved
|
I think this is a positive change and it might make more obvious that users can type to search for internal content, instead of copying and pasting links.
+1. Another interesting way of ordering content suggestions could be displaying pages already linked to the site's menu. A use-case to justify would be an SMB owner creating posts for their company blog and cross-linking to pages in the site's menu like Contact or Services/Shop as a way to direct visitors coming from search engines to the rest of the site. |
I was thinking that too, but technically it's likely a heavy lift. |
What does this mean? |
3 tasks
Prioritizing the items in your header navigation for example. |
|
Why is prioritising items already linked to good? |
…ges" This reverts commit b7cb1fe.
getdave
force-pushed
the
try/show-pages-suggestions-in-rich-text-link-ui
branch
from
0eff53b to
ba8eaa3
Compare
|
@draganescu @richtabor I updated the PR to limit the configuration of initial suggestions to the rich text implementation only. |
|
Flaky tests detected in ba8eaa3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7639111344
|
draganescu
approved these changes
Jan 24, 2024
getdave
dismissed
richtabor’s stale review
Rich said only blocker was Navigation. That's now not effected by changes in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upon opening the Link UI to create a new link in a rich text, the component will now display a set of initial suggestions. These are defaulted to pages.
Why?
Part of #50884.
How?
Set the defaults for all initial suggestions queries to be pages.
Enable the correct prop on the LinkConrol used in rich text links.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast