Support linkTarget of core/button for Pattern Overrides
#57947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevin940726
added
[Feature] Synced Patterns
|
This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress. If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged. If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack. Thank you! ❤️ View changed files❔ lib/block-supports/pattern.php ❔ lib/experimental/block-bindings/class-wp-block-bindings.php ❔ lib/experimental/block-bindings/sources/pattern.php ❔ lib/experimental/blocks.php |
|
Size Change: +37 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
kevin940726
force-pushed
the
fix/undefined-overrides
branch
from
7f6ac08 to
c34e1ad
Compare
This was referenced Jan 19, 2024
|
Superseded by #58587. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #53705.
Support the
linkTargetattribute of the button block for Pattern Overrides. Currently, the attribute relies onundefinedto represent "no target". We need a way to representundefinedvalues for attributes to be able to override the pattern.Why?
Because you can edit link target when editing the URL of the button block but it was never saved to the pattern instance.
How?
Use a special flag
WP_Block_Bindings::SKIPon the server side to represent skipping the processing of the attribute instead of usingnull. This also means we're treatingundefined(unset) andnullas the same value for attributes. This might not always be true for third-party blocks though. If this doesn't work then we'll look for other alternatives.Testing Instructions
Follow the instructions in #53705 (comment) to create a pattern with overrides.
linkTargetattribute. (This could become a backward-compat concern that we'll need to deal with in a follow-up task.)Screenshots or screencast
TBD