From 371812e0bc810fc4a7d120c9aaef629fa7708dac Mon Sep 17 00:00:00 2001 From: Carlos Bravo Date: Tue, 30 Jan 2024 16:27:20 +0100 Subject: [PATCH] Revert "Add defaultFontSizes option to theme.json (#56661)" This reverts commit 940f0fe52cfd1e3599e507a7d3f83146914e978f. --- .../theme-json-reference/theme-json-living.md | 1 - lib/class-wp-theme-json-gutenberg.php | 29 +++++----- lib/theme.json | 1 - .../src/components/global-styles/hooks.js | 2 - .../global-styles/typography-panel.js | 58 +++++-------------- packages/block-editor/src/hooks/utils.js | 20 ++----- packages/block-editor/src/utils/object.js | 16 ----- schemas/json/theme.json | 5 -- 8 files changed, 31 insertions(+), 101 deletions(-) diff --git a/docs/reference-guides/theme-json-reference/theme-json-living.md b/docs/reference-guides/theme-json-reference/theme-json-living.md index d9389597b89da..c58b8b3239f33 100644 --- a/docs/reference-guides/theme-json-reference/theme-json-living.md +++ b/docs/reference-guides/theme-json-reference/theme-json-living.md @@ -177,7 +177,6 @@ Settings related to typography. | Property | Type | Default | Props | | --- | --- | --- |--- | -| defaultFontSizes | boolean | true | | | customFontSize | boolean | true | | | fontStyle | boolean | true | | | fontWeight | boolean | true | | diff --git a/lib/class-wp-theme-json-gutenberg.php b/lib/class-wp-theme-json-gutenberg.php index 2ebebeaaaf307..e23b0c88dd707 100644 --- a/lib/class-wp-theme-json-gutenberg.php +++ b/lib/class-wp-theme-json-gutenberg.php @@ -155,7 +155,7 @@ class WP_Theme_JSON_Gutenberg { ), array( 'path' => array( 'typography', 'fontSizes' ), - 'prevent_override' => array( 'typography', 'defaultFontSizes' ), + 'prevent_override' => false, 'use_default_names' => true, 'value_func' => 'gutenberg_get_typography_font_size_value', 'css_vars' => '--wp--preset--font-size--$slug', @@ -413,20 +413,19 @@ class WP_Theme_JSON_Gutenberg { 'defaultPresets' => null, ), 'typography' => array( - 'fluid' => null, - 'customFontSize' => null, - 'defaultFontSizes' => null, - 'dropCap' => null, - 'fontFamilies' => null, - 'fontSizes' => null, - 'fontStyle' => null, - 'fontWeight' => null, - 'letterSpacing' => null, - 'lineHeight' => null, - 'textColumns' => null, - 'textDecoration' => null, - 'textTransform' => null, - 'writingMode' => null, + 'fluid' => null, + 'customFontSize' => null, + 'dropCap' => null, + 'fontFamilies' => null, + 'fontSizes' => null, + 'fontStyle' => null, + 'fontWeight' => null, + 'letterSpacing' => null, + 'lineHeight' => null, + 'textColumns' => null, + 'textDecoration' => null, + 'textTransform' => null, + 'writingMode' => null, ), ); diff --git a/lib/theme.json b/lib/theme.json index b7bc3cb89e60f..c2ed7fdca39ed 100644 --- a/lib/theme.json +++ b/lib/theme.json @@ -236,7 +236,6 @@ }, "typography": { "customFontSize": true, - "defaultFontSizes": true, "dropCap": true, "fontSizes": [ { diff --git a/packages/block-editor/src/components/global-styles/hooks.js b/packages/block-editor/src/components/global-styles/hooks.js index 7c5cf4cbf3e0f..6be5481a633da 100644 --- a/packages/block-editor/src/components/global-styles/hooks.js +++ b/packages/block-editor/src/components/global-styles/hooks.js @@ -67,7 +67,6 @@ const VALID_SETTINGS = [ 'spacing.units', 'typography.fluid', 'typography.customFontSize', - 'typography.defaultFontSizes', 'typography.dropCap', 'typography.fontFamilies', 'typography.fontSizes', @@ -240,7 +239,6 @@ export function useSettingsForBlockElement( ...updatedSettings.typography, fontSizes: {}, customFontSize: false, - defaultFontSizes: false, }; } diff --git a/packages/block-editor/src/components/global-styles/typography-panel.js b/packages/block-editor/src/components/global-styles/typography-panel.js index cc8b0589644bd..5347ddab92265 100644 --- a/packages/block-editor/src/components/global-styles/typography-panel.js +++ b/packages/block-editor/src/components/global-styles/typography-panel.js @@ -22,7 +22,7 @@ import TextTransformControl from '../text-transform-control'; import TextDecorationControl from '../text-decoration-control'; import WritingModeControl from '../writing-mode-control'; import { getValueFromVariable, TOOLSPANEL_DROPDOWNMENU_PROPS } from './utils'; -import { setImmutably, uniqByProperty } from '../../utils/object'; +import { setImmutably } from '../../utils/object'; const MIN_TEXT_COLUMNS = 1; const MAX_TEXT_COLUMNS = 6; @@ -53,10 +53,7 @@ export function useHasTypographyPanel( settings ) { function useHasFontSizeControl( settings ) { return ( - ( settings?.typography?.defaultFontSizes !== false && - settings?.typography?.fontSizes?.default?.length ) || - settings?.typography?.fontSizes?.theme?.length || - settings?.typography?.fontSizes?.custom?.length || + hasMergedOrigins( settings?.typography?.fontSizes ) || settings?.typography?.customFontSize ); } @@ -103,45 +100,16 @@ function useHasTextColumnsControl( settings ) { return settings?.typography?.textColumns; } -/** - * TODO: The reversing and filtering of default font sizes is a hack so the - * dropdown UI matches what is generated in the global styles CSS stylesheet. - * - * This is a temporary solution until #57733 is resolved. At which point, - * the mergedFontSizes would just need to be the concatenated array of all - * presets or a custom dropdown with sections for each. - * - * @see {@link https://github.com/WordPress/gutenberg/issues/57733} - * - * @param {Object} settings The global styles settings. - * - * @return {Array} The merged font sizes. - */ -function getMergedFontSizes( settings ) { - // The font size presets are merged in reverse order so that the duplicates - // that may defined later in the array have higher priority to match the CSS. - const mergedFontSizesAll = uniqByProperty( - [ - settings?.typography?.fontSizes?.custom, - settings?.typography?.fontSizes?.theme, - settings?.typography?.fontSizes?.default, - ].flatMap( ( presets ) => presets?.toReversed() ?? [] ), - 'slug' - ).reverse(); - - // Default presets exist in the global styles CSS no matter the setting, so - // filtering them out in the UI has to be done after merging. - const mergedFontSizes = - settings?.typography?.defaultFontSizes === false - ? mergedFontSizesAll.filter( - ( { slug } ) => - ! [ 'small', 'medium', 'large', 'x-large' ].includes( - slug - ) - ) - : mergedFontSizesAll; - - return mergedFontSizes; +function getUniqueFontSizesBySlug( settings ) { + const fontSizes = settings?.typography?.fontSizes; + const mergedFontSizes = fontSizes ? mergeOrigins( fontSizes ) : []; + const uniqueSizes = []; + for ( const currentSize of mergedFontSizes ) { + if ( ! uniqueSizes.some( ( { slug } ) => slug === currentSize.slug ) ) { + uniqueSizes.push( currentSize ); + } + } + return uniqueSizes; } function TypographyToolsPanel( { @@ -217,7 +185,7 @@ export default function TypographyPanel( { // Font Size const hasFontSizeEnabled = useHasFontSizeControl( settings ); const disableCustomFontSizes = ! settings?.typography?.customFontSize; - const mergedFontSizes = getMergedFontSizes( settings ); + const mergedFontSizes = getUniqueFontSizesBySlug( settings ); const fontSize = decodeValue( inheritedValue?.typography?.fontSize ); const setFontSize = ( newValue, metadata ) => { diff --git a/packages/block-editor/src/hooks/utils.js b/packages/block-editor/src/hooks/utils.js index f13963933e522..2f7a8f3a81f19 100644 --- a/packages/block-editor/src/hooks/utils.js +++ b/packages/block-editor/src/hooks/utils.js @@ -177,10 +177,7 @@ export function useBlockSettings( name, parentLayout ) { backgroundImage, backgroundSize, fontFamilies, - userFontSizes, - themeFontSizes, - defaultFontSizes, - defaultFontSizesEnabled, + fontSizes, customFontSize, fontStyle, fontWeight, @@ -227,10 +224,7 @@ export function useBlockSettings( name, parentLayout ) { 'background.backgroundImage', 'background.backgroundSize', 'typography.fontFamilies', - 'typography.fontSizes.custom', - 'typography.fontSizes.theme', - 'typography.fontSizes.default', - 'typography.defaultFontSizes', + 'typography.fontSizes', 'typography.customFontSize', 'typography.fontStyle', 'typography.fontWeight', @@ -314,12 +308,9 @@ export function useBlockSettings( name, parentLayout ) { custom: fontFamilies, }, fontSizes: { - custom: userFontSizes, - theme: themeFontSizes, - default: defaultFontSizes, + custom: fontSizes, }, customFontSize, - defaultFontSizes: defaultFontSizesEnabled, fontStyle, fontWeight, lineHeight, @@ -356,10 +347,7 @@ export function useBlockSettings( name, parentLayout ) { backgroundImage, backgroundSize, fontFamilies, - userFontSizes, - themeFontSizes, - defaultFontSizes, - defaultFontSizesEnabled, + fontSizes, customFontSize, fontStyle, fontWeight, diff --git a/packages/block-editor/src/utils/object.js b/packages/block-editor/src/utils/object.js index c78fe0e656dfe..8f6c82a9c3991 100644 --- a/packages/block-editor/src/utils/object.js +++ b/packages/block-editor/src/utils/object.js @@ -49,19 +49,3 @@ export const getValueFromObjectPath = ( object, path, defaultValue ) => { } ); return value ?? defaultValue; }; - -/** - * Helper util to filter out objects with duplicate values for a given property. - * - * @param {Object[]} array Array of objects to filter. - * @param {string} property Property to filter unique values by. - * - * @return {Object[]} Array of objects with unique values for the specified property. - */ -export function uniqByProperty( array, property ) { - const seen = new Set(); - return array.filter( ( item ) => { - const value = item[ property ]; - return seen.has( value ) ? false : seen.add( value ); - } ); -} diff --git a/schemas/json/theme.json b/schemas/json/theme.json index 38eac461b6b7b..1c2d20238aa32 100644 --- a/schemas/json/theme.json +++ b/schemas/json/theme.json @@ -489,11 +489,6 @@ "description": "Settings related to typography.", "type": "object", "properties": { - "defaultFontSizes": { - "description": "Allow users to choose font sizes from the default font size presets.", - "type": "boolean", - "default": true - }, "customFontSize": { "description": "Allow users to set custom font sizes.", "type": "boolean",