Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactivity API docs: Fix WP version, update new store docs #59107

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

cbravobernal
Copy link
Contributor

What?

Update docs, mentioning that the Interactivity is included in Core in 6.5.
Update the docs with the replacement of the wp_store function to wp_interactivity_state.

Copy link

github-actions bot commented Feb 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: c4rl0sbr4v0 <cbravobernal@git.wordpress.org>
Co-authored-by: SantosGuillamot <santosguillamot@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Feb 15, 2024

Flaky tests detected in 9ac38d4.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7974168585
📝 Reported issues:

Copy link
Contributor

@SantosGuillamot SantosGuillamot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🙂 I just left a couple of small comments.

Comment on lines 920 to 921
> **Note**
> We will rename `wp_store` to `wp_initial_state` in a future version.
> The store is called wp_interactivity_state
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we can just remove this note.

Comment on lines 947 to 948
)
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
)
);
) );

There is an extra space here.

@cbravobernal cbravobernal force-pushed the docs/update-interactivity-api-reference branch from d03a7c6 to 522ae2d Compare February 20, 2024 12:14
@cbravobernal cbravobernal enabled auto-merge (squash) February 20, 2024 13:21
@cbravobernal cbravobernal merged commit 3888f1e into trunk Feb 20, 2024
55 of 56 checks passed
@cbravobernal cbravobernal deleted the docs/update-interactivity-api-reference branch February 20, 2024 19:45
@github-actions github-actions bot added this to the Gutenberg 17.8 milestone Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Packages] Interactivity /packages/interactivity [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants