Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search block: use font size for search icon #59159

Merged
merged 11 commits into from
Feb 22, 2024
Merged

Search block: use font size for search icon #59159

merged 11 commits into from
Feb 22, 2024

Commits on Feb 22, 2024

  1. Update filename 

    First commit:
Apply font size to icon dimensions for the search block
In the case of presets, try fetching font size preset using slug from settings
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    37c3dc6 View commit details
    Browse the repository at this point in the history

  2. Linting, refactor

    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    137c6d9 View commit details
    Browse the repository at this point in the history

  3. Moving useFontSizeFromPreset into block editor private APIs 

    In the PHP file, take into account the custom origin as a priority to match editor behaviour. See: `getUniqueFontSizesBySlug()`
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    4be2655 View commit details
    Browse the repository at this point in the history

  4. Made it clear where the origin prioritization comes from in the comme… 

    …nts.

Made it clear where the origin prioritization comes from in the comments.
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    46b3d1b View commit details
    Browse the repository at this point in the history

  5. No null coalescing operator in Core yet. 

    escaping incoming attributes
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    b0bbbfd View commit details
    Browse the repository at this point in the history

  6. Revert getting font size from preset in the edit.js file. Use compute… 

    …d font size instead.

This is so it works in global styles as well.
Temporary bug fix for global styles, which should be done in another PR

revert space
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3ead67f View commit details
    Browse the repository at this point in the history

  7. wp

    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    87756ce View commit details
    Browse the repository at this point in the history

  8. lint

    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    223e32f View commit details
    Browse the repository at this point in the history

  9. esc_attr

    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    0826553 View commit details
    Browse the repository at this point in the history

  10. strict me

    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    e7c0ff0 View commit details
    Browse the repository at this point in the history

  11. Revert other stuff. 

    Use `em` for search icon.
    @ramonjd
    ramonjd committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    3f49b04 View commit details
    Browse the repository at this point in the history