Add: Command click to select item on table view. #59563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +54 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
jorgefilipecosta
force-pushed
the
add/cmd-click-to-select-item-on-table-view
branch
from
1322627 to
2f34967
Compare
jorgefilipecosta
force-pushed
the
add/cmd-click-to-select-item-on-table-view
branch
from
2f34967 to
dd7c7e7
Compare
|
Catching up now! Looks good, but let's keep an eye on this one, because there are no real precedents for capture-time listeners in Gutenberg. This feels too easy, it could backfire. ;) |
|
Just noting a small issue that occurs on the templates page where some items are un-selectable. There's a quick flash where the checkbox appears checked, then unchecks itself: flash.mp4 |
Thanks! Fix at #59697. @jorgefilipecosta, see if you agree with my change in ViewGrid. |
bph
added
[Feature] DataViews
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cmd + click/ ctrl + click as a way to select items on table view matching grid view behavior.
It takes advantage of onClickCapture react API (thanks @mcsf for the tip).
What?
Open the pages list wp-admin/site-editor.php?path=%2Fpages.
Verify it is possible to select table items by clicking and pressing cmd on any part of the table row.