[Data Views]: Remove separator in item actions #59822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -45 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in af8be87820068a24d9f5e1693f55f65dee6ee383. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8264528733
|
jameskoster
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Thanks Nik, this works well for me. It's good to see 'Delete' as the last item :)
In the future we may need to re-introduce separators, but I think it's quite likely their placement will be contextual to the post type in question, and tricky to systematise. So this seems good to merge.
ntsekouras
force-pushed
the
update/dataviews-item-actions
branch
from
af8be87 to
10288c4
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Mar 27, 2024
Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jameskoster <jameskoster@git.wordpress.org> Co-authored-by: mcsf <mcsf@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes the separator in item actions dialog and since we show both primary and secondary actions there, we can refactor the code a bit.
Additionally, the
deleteis now rendered at the bottom of the dialog to reduce its prominence. In the future we'll probably need some grouping of actions in a contextual way, but not for now.Testing Instructions
Deleteaction is at the bottom of the dialog