Editor: Update post URL component #60632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
force-pushed
the
update/post-url-component
branch
from
bbc05bd to
28763e0
Compare
ntsekouras
commented
Apr 10, 2024
| <div> | ||
| { isEditable && ( | ||
| <InputControl | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
This is probably the most noticeable difference. I replaced TextControl with InputControl. This way we also have the prefix/suffix support.
|
Here's trunk for reference:
Here's the PR:
This is better in most ways, but there are a few small things. We should probably still call it URL. Slug, to most people, means a type of snail. This is technically already an issue, but would be nice to fix. Instead of "Learn more. ↗", the link should be "Learn more↗." with the ↗ before the period. The URL below needs a bit of space above it, same space as if it were helptext: So that's 8px: The space between the / and the slug part of the URL is a bit big. You can probably set that to zero:
|
|
Size Change: +485 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
5 tasks
😆 😆 If we call it |
That was one of the motivations for using the term 'Slug'. The full URL that you see on trunk isn't very helpful imo. That said I agree it's a bit technical (or zoological 🐌). Is "Post slug" a compromise, or perhaps "Post path", "Post URL"? The link beneath the input should have help-text sizing (12px), and (ideally) coloring too (#gray-700). If that causes an issue then perhaps we could try something like: 
What do you think? |
I think we can do that with the current design with some css. With the alternative suggested design it might make things a bit more complex since we'll try to add the view page link in the control's label row.. Additionally the
I think we should see this in a different PR as it's about So, we need to decide on the label of the panel row and the button's label that triggers the dialog, so I can update the PR and land this. |
|
Flaky tests detected in f56888a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8642598008
|
How about Link? |
I think that would work for the panel row to be |
|
It would also match the verbiag of the link dialog. |
|
Okay, this seems ready for a final review. Thanks all! |
jorgefilipecosta
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
The code change looks good and worked well on my tests.
There is something I guess we can improve, in a case where the slug is not part of the permalink e.g: in the default plain links we still say the slug forms the last part of the URL which is not true in that case:
Previously we just showed the link without any message:
I guess we could improve and say a message saying slugs are not being used in the URL and that can be changed on the settings or something similar. Can be done in a follow up.
|
"Link" works well I think. I removed the reference to the 'slug' and 'page' (reads oddly when editing a post) in the copy. To Jorge's point, I do wonder if the copy should be help text on the input, so that it isn't displayed when you cannot customise the link. A couple of other considerations:
|
We can hide it if it's not editable and preserve the current design above the input.
We can try that, yes.
We can do that too. |
jameskoster
approved these changes
Apr 11, 2024
|
I addressed the last feedback except for the auto focus on input and :
We can refine in follow ups.. |
anomiex
added a commit
to Automattic/wp-calypso
that referenced
this pull request
May 3, 2024
PR #90225 updated a test to pass in the run against the nightly Gutenberg release after WordPress/gutenberg#60632 changed some labels. Unfortunately that broke the runs against released versions of Gutenberg. This adjusts the test to match both the old and new labels, with a TODO comment pointing out that it can be adjusted once that Gutenberg change is released to all the environments we test against.
Merged
7 tasks
anomiex
added a commit
to Automattic/wp-calypso
that referenced
this pull request
May 3, 2024
…90283) PR #90225 updated a test to pass in the run against the nightly Gutenberg release after WordPress/gutenberg#60632 changed some labels. Unfortunately that broke the runs against released versions of Gutenberg. This adjusts the test to match both the old and new labels, with a TODO comment pointing out that it can be adjusted once that Gutenberg change is released to all the environments we test against.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #60291
This PR updates the post url component that is used for updating the post's slug. Designs are from the linked issue: #60291 (comment)
Testing Instructions
Screenshots or screencast