Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update template and template parts labels #61146

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

ntsekouras
Copy link
Contributor

@ntsekouras ntsekouras commented Apr 26, 2024

What?

This PR updates the template and template parts labels to use a specific item_updated label. Without it, if you save/update a template or template part the notification message renders post updated.

I noticed this in this PR that brings the publish flow to site editor, but the issue is in post editor too right now, when you edit a template or template part and save.

Testing Instructions

  1. In post editor edit a template and save.
  2. Observe that the notification renders Template updated.
  3. Do the same for a template part and observe that it renders Template part updated.

Screenshots or screencast

Screen.Recording.2024-04-26.at.3.48.03.PM.mov

@ntsekouras ntsekouras added [Type] Enhancement A suggestion for improvement. Needs PHP backport Needs PHP backport to Core labels Apr 26, 2024
@ntsekouras ntsekouras self-assigned this Apr 26, 2024
Copy link

github-actions bot commented Apr 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@Mamaduka Mamaduka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected ✅

Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. We may want to open a trac ticket and backport this one quickly.

@ntsekouras ntsekouras merged commit 0b185ea into trunk Apr 26, 2024
69 checks passed
@ntsekouras ntsekouras deleted the update/template-and-template-parts-labels branch April 26, 2024 14:08
@github-actions github-actions bot added this to the Gutenberg 18.3 milestone Apr 26, 2024
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Apr 29, 2024
…art` post types.

This adds the `item_updated` label to Template and Template Part post types registration. This prevents from displaying the default `post updated` label.
See WordPress/gutenberg#61146 

Follow-up to [52062], [51003].

Props ntsekouras, ellatrix.
Fixes #61095.




git-svn-id: https://develop.svn.wordpress.org/trunk@58055 602fd350-edb4-49c9-b593-d223f7449a82
@audrasjb
Copy link
Contributor

Merged to Core in https://core.trac.wordpress.org/changeset/58055

@audrasjb audrasjb added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Apr 29, 2024
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Apr 29, 2024
…art` post types.

This adds the `item_updated` label to Template and Template Part post types registration. This prevents from displaying the default `post updated` label.
See WordPress/gutenberg#61146 

Follow-up to [52062], [51003].

Props ntsekouras, ellatrix.
Fixes #61095.



Built from https://develop.svn.wordpress.org/trunk@58055


git-svn-id: http://core.svn.wordpress.org/trunk@57520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
github-actions bot pushed a commit to platformsh/wordpress-performance that referenced this pull request Apr 29, 2024
…art` post types.

This adds the `item_updated` label to Template and Template Part post types registration. This prevents from displaying the default `post updated` label.
See WordPress/gutenberg#61146 

Follow-up to [52062], [51003].

Props ntsekouras, ellatrix.
Fixes #61095.



Built from https://develop.svn.wordpress.org/trunk@58055


git-svn-id: https://core.svn.wordpress.org/trunk@57520 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pbearne pushed a commit to pbearne/wordpress-develop that referenced this pull request May 8, 2024
…art` post types.

This adds the `item_updated` label to Template and Template Part post types registration. This prevents from displaying the default `post updated` label.
See WordPress/gutenberg#61146 

Follow-up to [52062], [51003].

Props ntsekouras, ellatrix.
Fixes #61095.




git-svn-id: https://develop.svn.wordpress.org/trunk@58055 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants