DataViews: More dataviews types #61193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
youknowriad
requested review from
oandregal,
sirreal,
jorgefilipecosta and
ntsekouras
|
Size Change: +279 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
Apr 29, 2024
| @@ -69,24 +56,3 @@ export const SORTING_DIRECTIONS = { | |||
| export const LAYOUT_TABLE = 'table'; | |||
| export const LAYOUT_GRID = 'grid'; | |||
| export const LAYOUT_LIST = 'list'; | |||
|
|
|||
| export const VIEW_LAYOUTS = [ | |||
There was a problem hiding this comment.
I moved this out of this file because it would have required typing all the components and I needed the constants file to be typed.
youknowriad
commented
Apr 29, 2024
| const field = _fields.find( | ||
| ( _field ) => _field.id === filter.field | ||
| ); | ||
| if ( field ) { |
There was a problem hiding this comment.
This is a small thing but typescript makes you consider edge cases that you can easily miss like here.
youknowriad
commented
Apr 29, 2024
youknowriad
added
the
[Feature] DataViews
sirreal
approved these changes
Apr 29, 2024
| /** | ||
| * The layout of the view. | ||
| */ | ||
| type: string; |
There was a problem hiding this comment.
It looks like this could also be a union of constants:
Suggested change
| type: string; | |
| type: 'table' | 'grid' | 'list'; |
There was a problem hiding this comment.
I think this list is going to be dynamic (registering layouts) ultimately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #61185
What?
The DataViews package is a types heavy package. There's a lot of structures that need to be documented properly. So this continues the effort to add explicit types to the package.
This one adds:
Testing instructions
There's no functional change, it's essentially a code quality + documentation change.