Editor: move around wordcount, post status and last edited info in page summary #61235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsekouras
added
[Type] Enhancement
ntsekouras
requested review from
Mamaduka,
youknowriad,
jameskoster and
jasmussen
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ntsekouras
commented
Apr 30, 2024
| @@ -32,8 +33,12 @@ export default function PageSummary( { | |||
| <PluginPostStatusInfo.Slot> | |||
| { ( fills ) => ( | |||
| <> | |||
| <PostFeaturedImagePanel withPanelBody={ false } /> | |||
| <PrivatePostExcerptPanel /> | |||
| <VStack spacing={ 2 }> | |||
There was a problem hiding this comment.
Styling in this Vstack should match this one: https://github.com/WordPress/gutenberg/pull/61235/files#diff-89b172fd62da4f8d2f19034e869e07494dffe29c7bcebf893ae1d4ddcbc2093bR85 for now.
|
Size Change: +233 B (+0.01%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
|
Can we have a before/after screenshot for this PR to understand its impact? |
|
Should the description on the right sidebar also be updated to show the word count and time to read directly there? 
|
| } from '../../store/constants'; | ||
|
|
||
| // Taken from packages/editor/src/components/time-to-read/index.js. | ||
| const AVERAGE_READING_RATE = 189; |
There was a problem hiding this comment.
nitpick: Could we just export the constant from the other file, now that they are on the same package?
jorgefilipecosta
approved these changes
Apr 30, 2024
Thanks for the review! I converted this to draft though because since the
The plan is to remove the details panel, so no need for updates there..
Will do after pushing some more changes. |
ntsekouras
force-pushed
the
move-around-some-post-summary-panels
branch
from
f35dc38 to
2df9c31
Compare
ntsekouras
changed the title
|
I updated the PR's description with before/after images and also moved the post status panel too. |
ntsekouras
commented
Apr 30, 2024
Mamaduka
approved these changes
May 1, 2024
Comment on lines
+53
to
+54
| title: | ||
| _templateInfo?.title || getEditedPostAttribute( 'title' ), |
There was a problem hiding this comment.
Nit: We can use _record?.title here.
| const { getEditedPostAttribute, getCurrentPostType, getCurrentPostId } = | ||
| select( editorStore ); | ||
| const { getEntityRecord } = select( coreStore ); | ||
| const siteSettings = getEntityRecord( 'root', 'site' ); |
There was a problem hiding this comment.
Note: This will result in 403 requests for non-Admin users. I'm tracking this separately - #60987.
|
It only required a couple of lines of CSS, so I updated the 'Set featured image' button to match the design (based on other similar buttons in the Editor). @ntsekouras if you prefer to do that in a separate PR feel free to revert. |
jameskoster
approved these changes
May 1, 2024
ntsekouras
force-pushed
the
move-around-some-post-summary-panels
branch
from
5d85c25 to
e8909af
Compare
|
Flaky tests detected in e8909af. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/8919565688
|
This was referenced Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of: #59689
This PR moves around some components based on the updated designs shared here.
Notes
There will be a follow up for the PostExcerpt panel with the a11y concerns.
Testing Instructions
Page with no image and no excerpt
Post with image and excerpt