Editor: Update and simplify the Post Summary and Post Card section in the document sidebar #61624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the document sidebar
youknowriad
added
[Type] Enhancement
youknowriad
requested review from
Mamaduka,
jameskoster,
jorgefilipecosta and
ntsekouras
|
Size Change: -263 B (-0.02%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
May 13, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
reviewed
May 13, 2024
Mamaduka
reviewed
May 13, 2024
| className="editor-post-card-panel__description" | ||
| spacing={ 2 } | ||
| > | ||
| <PrivatePostExcerptPanel /> |
There was a problem hiding this comment.
We're are we rendering this element?
This change is causing remaining e2e test failure.
There was a problem hiding this comment.
We're rendering it but in a consistent place (it was rendered in two different places for different post types)
There was a problem hiding this comment.
Can you link where? Sorry if I'm missing the obvious logic change, but keeping up with all the unify/redesign changes for the sidebar is a bit tricky.
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry for the confusion. This works as expected.
P.S. We need to add some doc block comments for PrivatePostExpectPanel and PostExpectPanel to make them easily distinguishable without needing to read the logic.
cc @ntsekouras
It looks like the gap between the word count and the meta rows below shrunk a little – it should be 24px. Otherwise this looks good! |
yes, because I tried using a consistent spacing between the "big" elements of the panel. Having something specific just for that space seemed weird to me. |
|
I tried to find a middle ground between increasing the space between "meta rows" and "word count" while keeping the gap consistent between the different "sections" of the summary panel. |
Mamaduka
approved these changes
May 14, 2024
|
@Mamaduka Thanks for all the e2e fixes :) |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #59689
What?
This PR iterates towards the designs shared in #59689
It's not meant to solve everything yet but it does a few things that moves us in the right direction:
Testing Instructions
Open the post or site editor for the following post types:
Ensure the summary looks correct and is consistent.
Screenshots or screencast