DataViews: Expand typing more components #61654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
commented
May 14, 2024
| if ( ! totalItems || ! totalPages ) { | ||
| return null; | ||
| } | ||
| const currentPage = view.page ?? 1; |
There was a problem hiding this comment.
I suspect that this might fix some subtle bugs where the "page" was undefined in views so next/previous buttons might have had bad behavior.
youknowriad
commented
May 14, 2024
| @@ -50,7 +50,7 @@ interface ListViewProps { | |||
| id: string; | |||
| isLoading: boolean; | |||
| onSelectionChange: ( selection: Item[] ) => void; | |||
| selection: Item[]; | |||
| selection: string[]; | |||
There was a problem hiding this comment.
I think the selection objects holds just the ids of the items but it's weird that the onSelectionChange receives the whole objects. It's not consistent but it's the way it is for now.
|
Size Change: +23 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
sirreal
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #61185
What?
The DataViews package is a types heavy package. There's a lot of structures that need to be documented properly. So this continues the effort to add explicit types to the package. This PR focuses on typing the Pagination and SingleSelectionCheckbox components
Testing instructions
There's no functional change, it's essentially a code quality + documentation change.