DataViews: Full type the dataviews package #61854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
commented
May 22, 2024
| } ); | ||
| } | ||
|
|
||
| // A type assertion is used here to keep the type argument. |
There was a problem hiding this comment.
I wonder why React doesn't do this by default using generics.
This reverts commit 78f2ac82066e53b8db43d1384ba2138efe014e6b.
youknowriad
force-pushed
the
update/fully-type-dataviews
branch
from
ce5738b to
e4ab2ce
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I know we shouldn't be using "as" too much but I'm not sure how to fix the ViewComponent thing, so I've used that for now. Consider updating it if you have a better solution. |
|
Size Change: -2.56 kB (-0.15%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
youknowriad
added
[Type] Code Quality
|
Flaky tests detected in 9399bcc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/9255893962
|
sirreal
approved these changes
May 27, 2024
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jun 4, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: sirreal <jonsurrell@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55083
Follow-up to #61185
What?
The DataViews package is a types heavy package. There's a lot of structures that need to be documented properly. So this continues the effort to add explicit types to the package. This PR types the root level DataViews component which basically makes the package fully typed.
Testing instructions
There should be no real change here, it's mostly code quality and documentation.