Try: Contextual frame bg color to avoid artifacting. #62223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +25 B (0%) Total Size: 1.74 MB
ℹ️ View Unchanged
|
MaggieCabrera
approved these changes
Jun 3, 2024
|
Thanks for the review. I'll let this one sit for a bit just to give others a chance to chime in. |
youknowriad
reviewed
Jun 3, 2024
| // Show a dark background in "frame" mode to avoid edge artifacts. | ||
| // Show a gray background in all other contexts, such as zoom. | ||
| background-color: $gray-900; | ||
| .is-full-canvas & { |
There was a problem hiding this comment.
is-full-canvas is a site editor class so this style should probably not live here. (same for the other file).
|
Good feedback, thanks for testing. I changed the approach to leverage the fact that the class was site editor only. What do you think? |
jasmussen
force-pushed
the
try/frame-bg-color
branch
from
1ba8e30 to
81205a3
Compare
youknowriad
reviewed
Jun 4, 2024
| width: 100%; | ||
| height: 100%; | ||
| display: block; | ||
| background-color: $gray-300; |
There was a problem hiding this comment.
So this background is not needed at all, even on the post editor?
There was a problem hiding this comment.
I was afraid that this would break Safari, but this is what I see:
There was a problem hiding this comment.
In my testing, these contexts inherit from the other class.
What do you say, good to land?
Edit: as always, happy to follow up.
youknowriad
reviewed
Jun 4, 2024
|
This one sat for a bit to gather feedback, but re-testing it this morning, I still can't reproduce any issues. Site editor in site view has dark canvas, all contexts in edit view inc. post editor and safari have the gray view. So I'll merge and be on deck for any followups. |
|
Should this be backported for WP 6.6? If so, please add the |
|
I'd like it backported, because it's a great fix for visually dark themes in the site editor. So I'll add the label, thanks for the reminder. It's also an entirely safe bugfix. But if it's chosen to not be backported, that also okay. |
jasmussen
added
the
Backport to WP 6.7 Beta/RC
ellatrix
added
[Type] Bug
|
Let's mark it as a bug fix then, the enhancement label confused me a bit |
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Try: Contextual frame bg color to avoid artifacting. * Try different fix. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
pushed a commit
that referenced
this pull request
Jun 11, 2024
* Try: Contextual frame bg color to avoid artifacting. * Try different fix. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
patil-vipul
pushed a commit
to patil-vipul/gutenberg
that referenced
this pull request
Jun 17, 2024
* Try: Contextual frame bg color to avoid artifacting. * Try different fix. Co-authored-by: jasmussen <joen@git.wordpress.org> Co-authored-by: MaggieCabrera <onemaggie@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
ellatrix
removed
the
Backport to WP 6.7 Beta/RC
|
This was cherry-picked to the wp/6.6 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
When you have a theme with a dark background, the scale-up animation of the frame in the site editor has a white halo artifacting itself due to rounding math in the scale-up process:
before.mp4
This is due to the light gray background that is applied to the frame background peeking out.
This PR solves that by contextually applying a dark background to the framed contexts:
after.mp4
What about when you're using a light theme, you might ask? The artifacting is still addressed in that case because the outer background is dark. So it's only an issue when it's a dark background, a light frame background, and then a dark content background inside.
Testing Instructions
Use a dark background, test the site editor, mouse over the frame to scale it up.
Note that previously the light gray background was applied specifically to address an issue with zoom out mode. Please do test that this still works.