DataViews: rename onSelectionChange to onChangeSelection
#63087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Enhancement
|
Size Change: -2 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Jul 3, 2024
| @@ -2,6 +2,8 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - `onSelectionChange` has been renamed to `onChangeSelection`. | |||
There was a problem hiding this comment.
This should be under a Breaking Changes section, right?
|
Regarding API coherence, we have
And
Imo, the |
|
Why do we have both |
|
I guess |
|
I'm going to rebase and merge this PR. and I'll explore removing |
youknowriad
force-pushed
the
update/on-selection-change-to-on-change-selection
branch
from
0dcb62e to
0c11094
Compare
youknowriad
added
[Feature] DataViews
youknowriad
deleted the
update/on-selection-change-to-on-change-selection
branch
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: oandregal <oandregal@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #55083
What?
Renames
onSelectionChangetoonChangeSelection.Why?
For API coherence. We are using
onChange*in a few properties:onChangeViewfor DataViews,onChangefor the upcomingDataFormat #63032.See conversation at #63032 (comment)
How?
Testing Instructions
Verify those pages still work as expected. Examples: