Zoom out: Disable 'Desktop (50%)' option in the non-iframed editor #64264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +21 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
ellatrix
reviewed
Aug 5, 2024
| { | ||
| // The "Desktop (50%)" option only works in the iframe editor, | ||
| // so disable it in the non-iframe editor. | ||
| ! disableIframe && { |
There was a problem hiding this comment.
Zoom-out should generally be disabled if there's no iframe
There was a problem hiding this comment.
Is there a way to get this value of disableIframe without passing it down in props?
There was a problem hiding this comment.
We might also need to disable the experimental zoomed-out view when the pattern category is selected and the editor is not an iframe, otherwise we'll be forcing "Desktop (50%)" even though it's not in the view options:
8ac90c830538f13f8d330a5810987d3b.mp4
Perhaps we need to know whether the editor is an iframe or not here, is there a way?
scruffian
approved these changes
Aug 5, 2024
|
This does fix the UI issue when the Zoom Out experiment is not enabled but I wonder if it’d be possible to instead force the iframe editor when Zoom Out engages as happens when editing the template or template part. If so it would also fix #62943. |
Thanks for the feedback! I think this approach is very simple and makes perfect sense. I've submitted #64316. |
|
Thank you everyone for your reviews. I think it makes sense to ship #64316, so I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64259
What?
This PR will disable the "Desktop (50%)" option if the editor is not iframed.
Why?
The "Desktop (50%)" view is a zoom-out mode. The zoom-out mode does not work properly if the editor is not an iframe.
From my understanding, it is difficult or requires significant modifications to make the zoom-out mode work in a non-iframe editor. Therefore, I think it is best to leave it disabled for now.
How?
We can determine if the editor is an iframe by checking the
disableIframe. If this istrue, exclude the "Desktop (50%)" option.Testing Instructions
This option is available if the custom field is disabled, otherwise it should not be visible.