ComboboxControl: Add lint rule for 40px size prop usage #64560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +309 B (+0.02%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
mirka
commented
Aug 15, 2024
| @@ -33,6 +33,7 @@ function UserControl( { value, onChange } ) { | |||
|
|
|||
| return ( | |||
| <ComboboxControl | |||
| __next40pxDefaultSize | |||
| { showAuthorControl && | ||
| ( ( showCombobox && ( | ||
| <ComboboxControl | ||
| __next40pxDefaultSize |
There was a problem hiding this comment.
The spacing gets messed up when a ComboboxControl enters the mix, because it has an additional div wrapper outside the BaseControl. The auto margin added to BaseControls by the block inspector interprets this as a :last-child BaseControl, and adds a smaller margin.
So here we add a VStack to explicitly handle our spacing, with the correct metrics (16px gap), and additional CSS to counteract the auto margins. Painful 😭 FYI I am working on this in #64526.
| Before | After |
|---|---|
 |
 |
Looks like this when showCombobox === false:
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
28 tasks
ciampo
reviewed
Aug 16, 2024
| @@ -66,5 +66,6 @@ | |||
| "clientNavigation": true | |||
| } | |||
| }, | |||
| "editorStyle": "wp-block-post-author-editor", | |||
There was a problem hiding this comment.
It's necessary because we're readding the editor style file and we want it to be taken into consideration when previewing the blocks in the editor.
tyxla
approved these changes
Aug 16, 2024
| @@ -66,5 +66,6 @@ | |||
| "clientNavigation": true | |||
| } | |||
| }, | |||
| "editorStyle": "wp-block-post-author-editor", | |||
There was a problem hiding this comment.
It's necessary because we're readding the editor style file and we want it to be taken into consideration when previewing the blocks in the editor.
|
Flaky tests detected in 563439d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10424509480
|
Mmm, thanks for excavating that. I read through the thread and they just removed the editor styles because they realized that the existing styles were duplicated in the main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #63871
What?
Add a lint rule to prevent people from introducing new usages of ComboboxControl that do not adhere to the new default size.
Testing Instructions
The lint error should trigger for violations as expected.