MediaPlaceholder: Use InputControl in URL popover #65656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirka
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
mirka
commented
Sep 25, 2024
| border: none; | ||
| border-radius: 0; | ||
| margin: 2px; | ||
| min-width: 260px; |
There was a problem hiding this comment.
The widths don't seem to be particularly intentional to begin with, so just using my best judgement here.
| display: flex; | ||
|
|
||
| // Selector requires a lot of specificity to override base styles. | ||
| input[type="url"].block-editor-media-placeholder__url-input-field { |
There was a problem hiding this comment.
Interestingly, these styles were not applying to the input as intended because it didn't have type="url".
To minimize the risk of unintended consequences for the scope of this PR, I didn't add a type="url" to the InputControl. Let me know if you disagree.
There was a problem hiding this comment.
Sounds good to me — it could be a change to consider, but not in the scope of this PR
|
Size Change: -74 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 347a0c8. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11036424654
|
mirka
added
the
Backport to WP 6.7 Beta/RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 30, 2024
* MediaPlaceholder: Use InputControl in URL popover * Tweak width in mobile Co-authored-by: mirka <0mirka00@git.wordpress.org> Co-authored-by: ciampo <mciampini@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 5458080 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #64709
What?
Replaces the raw
inputin the MediaPlaceholder URL popover with an InputControl, and move the submit button to the suffix slot like the other similar UI patterns.Why?
Easier and more consistent styling, as well as UI pattern consolidation among all the URL input controls.
Testing Instructions
Add an Image block. The "Insert from URL" flow should work as expected.
Screenshots or screencast
Desktop
Mobile