Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the navigation issue inside cover blocks #66093

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Fix the navigation issue inside cover blocks #66093

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
eb4dc79
Implement a simple solution for the navigation open inside the cover
renatho Oct 11, 2024
64c14d3
Add the has-modal-open to the editor reproducing the same behavior of…
renatho Oct 11, 2024
b6f62e2
Add test
renatho Oct 14, 2024
10e1007
Remove not necessary comment
renatho Oct 15, 2024
0a244ec
Update check to see if second cover inner blocks container is clickable
renatho Oct 15, 2024
0850938
Add useEffect cleanup to remove modal class
renatho Oct 16, 2024
efe0a9e
Refactor html element selector
renatho Oct 16, 2024
eaabc88
Make sure element exists before trying to remove the class
renatho Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/block-library/src/navigation/edit/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ function useResponsiveMenu( navRef ) {
return;
}

const htmlElement = navRef.current.closest( 'html' );
const htmlElement = navRef.current.ownerDocument.documentElement;

// Add a `has-modal-open` class to the <html> when the responsive
// menu is open. This reproduces the same behavior of the frontend.
Expand All @@ -91,6 +91,10 @@ function useResponsiveMenu( navRef ) {
} else {
htmlElement.classList.remove( 'has-modal-open' );
}

return () => {
htmlElement.classList.remove( 'has-modal-open' );
renatho marked this conversation as resolved.
Show resolved Hide resolved
};
}, [ navRef, isResponsiveMenuOpen ] );

return [ isResponsiveMenuOpen, setResponsiveMenuVisibility ];
Expand Down
Loading