Global styles revisions: move focus and active state to list item #66780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t up to an accessible list item. The result is that the list item is tabbable and selectable via keyboard, and the focus state wraps the entire item.
ramonjd
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @jarekmorawski. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -8 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
ntsekouras
reviewed
Nov 6, 2024
| @@ -120,7 +115,7 @@ function RevisionsButtons( { | |||
| <ol | |||
| className="edit-site-global-styles-screen-revisions__revisions-list" | |||
| aria-label={ __( 'Global styles revisions list' ) } | |||
| role="group" | |||
There was a problem hiding this comment.
Should we use Composite component here and also improve the revisions list keyboard navigation?
There was a problem hiding this comment.
Thanks for the tip, I'll try out the Composite component.
Should we use Composite component here and also improve the revisions list keyboard navigation?
Are those two points mutually exclusive or is the latter a consequence of the former?
I'd like to keep this PR within the scope of #66642.
There was a problem hiding this comment.
It can be iterated later, but it would probably change this added code too. It's fine to land this one first.
ramonjd
deleted the
update/global-styles-revisions-shift-event-to-list-item
branch
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…rdPress#66780) * This PR removes the button that loads the global revision and moves it up to an accessible list item. The result is that the list item is tabbable and selectable via keyboard, and the focus state wraps the entire item. * Use button border * Fix e2e tests and use composite component Unlinked contributors: jarekmorawski. Co-authored-by: ramonjd <ramonopoly@git.wordpress.org> Co-authored-by: ntsekouras <ntsekouras@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66642
What?
This PR removes the button that loads the global revision and moves it up to an accessible list item.
The result is that the list item is tabbable and selectable via keyboard, and the focus state wraps the entire item.
Thanks to @jarekmorawski for reporting.
Why?
To shift the visible focus to the list item itself, not a child button.
To wrap the select border around the entire item.
See the UI quirk reported by: #66642
How?
Give the ordered list a role of
"listbox"and the list items,"option".Move keyboard/click events to the
<li />.Testing Instructions
Testing Instructions for Keyboard
Tab through the list items. You should be able to:
2024-11-06.13.30.41.mp4
Screenshots or screencast