-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LineHeightControl: Deprecate 36px default size #67850
Conversation
Size Change: +49 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Flaky tests detected in 5db3d50. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12284123447
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Part of #65751
What?
Deprecates the 36px default size on
LineHeightControl
.Testing Instructions
A props combination like this in the component Storybook should not log a warning:
But unless there is a non-
'default'
size
prop, it should log a warning when__next40pxDefaultSize
is falsey.