Customizer Widgets: Fix inserter button size and animation #67880
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +186 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
tyxla
approved these changes
Dec 12, 2024
jameskoster
approved these changes
Dec 12, 2024
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #67440
What?
In the Customizer widget, do two things:
Why?
The inserter button was previously 24px in size:
Due to the influence of #67440, it seems that only the button width has changed from 24px to 32px.
How?
We could have changed it back to its original 24px size, but since the visual size of all the other buttons in this toolbar is 32px, I've changed the inserter button to be 32px square as well.
As for animations, the same styles are applied as in the Editor and Widget Editor:
gutenberg/packages/editor/src/components/document-tools/style.scss
Lines 18 to 25 in b1d943f
Testing Instructions
Screenshots or screencast