Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Block: Refactor settings panel to use ToolsPanel #67896

Merged

Conversation

Sukhendu2002
Copy link
Contributor

Part of: #67813

What?

Refactored Table Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Before After
image image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 12, 2024 21:11
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <sukhendu2002@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected and the code looks good 👍 Thanks for moving this forward :)

CleanShot.2024-12-12.at.23.33.24.mp4

@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Table Affects the Table Block labels Dec 12, 2024
@fabiankaegy fabiankaegy merged commit 8d6b8c5 into WordPress:trunk Dec 12, 2024
70 of 73 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Table block to use ToolsPanel instead of PanelBody
2 participants