Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with margin on blocks with no toolbars #753

Merged
merged 1 commit into from
May 10, 2017

Conversation

jasmussen
Copy link
Contributor

This fixes an issue with the current embed block placeholder, which has an empty toolbar. With the recent merge of the position sticky toolbars, we're using some negative margins, which when the toolbar isn't present, caused some bleed issues.

This fixes an issue with the current embed block placeholder, which has an empty toolbar. With the recent merge of the position sticky toolbars, we're using some negative margins, which when the toolbar isn't present, caused some bleed issues.
@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label May 10, 2017
@jasmussen jasmussen self-assigned this May 10, 2017
@jasmussen jasmussen requested a review from notnownikki May 10, 2017 11:38
@jasmussen jasmussen changed the title Fix issue with margi on blocks with no toolbars Fix issue with margin on blocks with no toolbars May 10, 2017
@jasmussen jasmussen requested a review from youknowriad May 10, 2017 11:42
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants