Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blocks/index.js is compat with the RN so, use it #7599

Merged
merged 1 commit into from
Jun 28, 2018
Merged

blocks/index.js is compat with the RN so, use it #7599

merged 1 commit into from
Jun 28, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 28, 2018 •
edited
Loading

Description

Removed the specialization-for-mobile of the blocks/index.js file.

How has this been tested?

Use wordpress-mobile/gutenberg-mobile#61 to test this PR by compiling and running the mobile GB app.

Screenshots

None

Types of changes

Dropped the native.js variant of the main Blocks index.js file as the web side one can normally be consumed by the mobile app now.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

gziolo
gziolo approved these changes Jun 28, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why Travis is failing. I restarted the node which gives some false negatives.

👍

@hypest
Copy link
Contributor Author

hypest commented Jun 28, 2018

Travis greened out so, will merge. Thanks for the review and Travis re-trigger @gziolo 🙇‍♂️

@hypest hypest merged commit ef5cfe0 into master Jun 28, 2018
@hypest hypest deleted the rnmobile/no-need-for-native-block-api-indexjs branch June 28, 2018 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hypest @gziolo