-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spacer block resizing #7799
Conversation
Thanks for looking into this. Unfortunately, this way, one can't get to the upper sibling inserter when selecting a Spacer block. P.S.: Edited the PR description to fix the "Fixes #xxxx" against the correct issue. |
Would it make more sense to just remove the drag handle from the top of the Spacer block? There is not really a need for one on both the top and bottom, and dragging from the top works a little oddly. |
cc @jasmussen |
The top resize handle and the sibling inserter are in the same spot. Removing the top resize handle is a simple fix.
d7c844e
to
138cda9
Compare
@noisysocks: thanks, though the upper sibling inserter is still inaccessible. :) |
🤔 perhaps this is intentional? @jasmussen? It looks like, in |
This is intentional for the sibling inserter when a block is selected and that block has no toolbar to cover the sibling inserter. It seems this aspect is non optimal when a block has no toolbar, as in the case of the spacer. As we look for a way to fix this let's be sure to not regress this sibling inserter behavior for blocks with toolbars. |
And by the way I thing it's fine to simply not show the top resizing handle. Your mouse is floating in air anyway, when you use it. |
I think then let's leave this as is. We can look at making the sibling inserter appear when the block has no toolbar in a seperate PR. Issue here: #7884 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
Fixes #7755.
The sibling inserter was preventing a user from being able to resize the spacer using the top drag handle.
To test: