Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: Add a new compose package #7948

Merged
merged 6 commits into from
Jul 16, 2018
Merged

Packages: Add a new compose package #7948

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c25c23b
Compose: Extract UI-less Higher order components into a wordpress/com…
youknowriad Jul 12, 2018
641f98a
Use a range version for lodash
youknowriad Jul 13, 2018
318ac15
Move createHigherOrderComponent to @wordpress/compose
youknowriad Jul 13, 2018
11d939a
Fix unit tests
youknowriad Jul 13, 2018
fd299fe
Remove useless dev dependency
youknowriad Jul 13, 2018
6c46a47
Compose: Use ranges for dev dependencies
gziolo Jul 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
"@wordpress/api-request": "file:packages/api-request",
"@wordpress/autop": "file:packages/autop",
"@wordpress/blob": "file:packages/blob",
"@wordpress/compose": "file:packages/compose",
"@wordpress/core-data": "file:packages/core-data",
"@wordpress/data": "file:packages/data",
"@wordpress/date": "file:packages/date",
Expand Down
3 changes: 2 additions & 1 deletion packages/compose/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,11 @@
"module": "build-module/index.js",
"dependencies": {
"@wordpress/element": "file:../element",
"@wordpress/is-shallow-equal": "file:packages/is-shallow-equal",
"@wordpress/is-shallow-equal": "file:../is-shallow-equal",
"lodash": "^4.17.10"
},
"devDependencies": {
"@wordpress/jest-console": "file:packages/jest-console",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it should be included here. We never import it explicitly in the test file.

"enzyme": "3.3.0",
"react-dom": "16.4.1",
"react-test-renderer": "16.4.1"
Expand Down
2 changes: 1 addition & 1 deletion packages/compose/src/create-higher-order-component/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { Component } from '@wordpress/element';
/**
* Internal dependencies
*/
import { createHigherOrderComponent } from '../';
import createHigherOrderComponent from '../';

describe( 'createHigherOrderComponent', () => {
it( 'should use default name for anonymous function', () => {
Expand Down
1 change: 0 additions & 1 deletion packages/element/src/test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { shallow } from 'enzyme';
* Internal dependencies
*/
import {
Component,
createElement,
concatChildren,
renderToString,
Expand Down