Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try darker bottom border color for input fields. #8037

Closed
wants to merge 1 commit into from

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Jul 18, 2018

Description

This PR seeks to explore an improved color contrast ratio for input fields as discussed in #7053, by making the bottom border color use a darker gray.

Ideally, all form elements should have at least a contrast ratio of 3:1 with the adjacent background. See:
https://www.w3.org/TR/WCAG21/#non-text-contrast
https://www.w3.org/WAI/WCAG21/Understanding/non-text-contrast.html

Of course, this applies to the controls themselves (e.g. their borders). Text still needs a contrast ratio of 4.5:1.

Other form elements, for example radio buttons, checkboxes, and selects, should be discussed and addressed separately.

@afercia afercia requested review from karmatosed and jasmussen July 18, 2018 21:41
@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Jul 18, 2018
Copy link
Member

@karmatosed karmatosed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now we need to rethink this a bit as it doesn't look great in placeholders.

@afercia
Copy link
Contributor Author

afercia commented Aug 3, 2018

Closing as a better solution is going to land in #8385

@afercia afercia closed this Aug 3, 2018
@afercia afercia deleted the update/improve-input-fields-contrast-ratio branch August 3, 2018 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants