From e9beb09f87757e4351ab9a04cd293305c978a9b1 Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Thu, 2 Aug 2018 14:39:59 +0100 Subject: [PATCH 1/3] chore: Add test for block mover (#8011) --- test/e2e/specs/block-mover.test.js | 40 ++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) create mode 100644 test/e2e/specs/block-mover.test.js diff --git a/test/e2e/specs/block-mover.test.js b/test/e2e/specs/block-mover.test.js new file mode 100644 index 0000000000000..5d1b77707c244 --- /dev/null +++ b/test/e2e/specs/block-mover.test.js @@ -0,0 +1,40 @@ +/** + * Internal dependencies + */ +import '../support/bootstrap'; +import { newPost, newDesktopBrowserPage } from '../support/utils'; + +describe( 'block mover', () => { + beforeEach( async () => { + await newDesktopBrowserPage(); + await newPost(); + } ); + + it( 'should show block mover when more than one block exists', async () => { + // Create a two blocks on the page. + await page.click( '.editor-default-block-appender' ); + await page.keyboard.type( 'First Paragraph' ); + await page.keyboard.press( 'Enter' ); + await page.keyboard.type( 'Second Paragraph' ); + + // Select a block so the block mover is rendered. + await page.focus( '.editor-block-list__block' ); + + const blockMover = await page.$$( '.editor-block-mover' ); + // There should be a block mover. + expect( blockMover ).toHaveLength( 1 ); + } ); + + it( 'should hide block mover when only one block exists', async () => { + // Create a single block on the page. + await page.click( '.editor-default-block-appender' ); + await page.keyboard.type( 'First Paragraph' ); + + // Select a block so the block mover has the possibility of being rendered. + await page.focus( '.editor-block-list__block' ); + + // Ensure no block mover exists when only one block exists on the page. + const blockMover = await page.$$( '.editor-block-mover' ); + expect( blockMover ).toHaveLength( 0 ); + } ); +} ); From b3e0acc761dc7aa35ef0cbfaf3e525e0591f724d Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Tue, 7 Aug 2018 23:50:26 +0100 Subject: [PATCH 2/3] chore: Remove await newDesktopBrowserPage(); --- test/e2e/specs/block-mover.test.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/e2e/specs/block-mover.test.js b/test/e2e/specs/block-mover.test.js index 5d1b77707c244..d865115d8974c 100644 --- a/test/e2e/specs/block-mover.test.js +++ b/test/e2e/specs/block-mover.test.js @@ -2,11 +2,10 @@ * Internal dependencies */ import '../support/bootstrap'; -import { newPost, newDesktopBrowserPage } from '../support/utils'; +import { newPost } from '../support/utils'; describe( 'block mover', () => { beforeEach( async () => { - await newDesktopBrowserPage(); await newPost(); } ); From 1c0da6eabf40eccb014650fde56edb5ec0aa0533 Mon Sep 17 00:00:00 2001 From: "Matthew Riley MacPherson (tofumatt)" Date: Wed, 8 Aug 2018 00:26:08 +0100 Subject: [PATCH 3/3] chore: Oops, that hasn't landed yet, haha --- test/e2e/specs/block-mover.test.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/e2e/specs/block-mover.test.js b/test/e2e/specs/block-mover.test.js index d865115d8974c..5d1b77707c244 100644 --- a/test/e2e/specs/block-mover.test.js +++ b/test/e2e/specs/block-mover.test.js @@ -2,10 +2,11 @@ * Internal dependencies */ import '../support/bootstrap'; -import { newPost } from '../support/utils'; +import { newPost, newDesktopBrowserPage } from '../support/utils'; describe( 'block mover', () => { beforeEach( async () => { + await newDesktopBrowserPage(); await newPost(); } );