Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paragraph splits on RN #8915

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented Aug 13, 2018

Description

This PR fixes a regression where trying to write multiple lines on a paragraph was making the RN example app crash.

How has this been tested?

Run the RN app on gutenberg mobile, using the branch for this PR, and make sure that the app does not crash when inserting multiple paragraphs on the paragraph block.

Screenshots

Types of changes

  • Bug fix on the RichText block
  • Added an entry point on new the block-library package.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@SergioEstevao SergioEstevao requested review from koke and gziolo August 13, 2018 10:47
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested but code changes look good given the context of the issue.

@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended labels Aug 13, 2018
@gziolo gziolo added this to the 3.6 milestone Aug 13, 2018
@hypest
Copy link
Contributor

hypest commented Aug 13, 2018

LGTM @SergioEstevao !

@SergioEstevao SergioEstevao merged commit 751a2fc into master Aug 13, 2018
@SergioEstevao SergioEstevao deleted the rnmobile/fix_paragraph_splits branch August 13, 2018 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants