Bring the preview tab to the front when clicking the preview button.

[youknowriad]

Testing instructions

• Try clicking the preview button, the preview tab should be brought to the front
• Same if you click multiple times
• Same if you click after making edits while the preview tab is open

[aduth]

Duplicates #8446

[youknowriad]

oups :)

[aduth]

We also need to refocus the window in all cases.

Can you elaborate on this? Is this intended to bring the tab to the front? I was under the impression this wouldn't be possible, but if focus works, I'm all for it.

[youknowriad]

Can you elaborate on this? Is this intended to bring the tab to the front?

Yes, exactly. I assume we need to test in several browsers, but yeah it works

[aduth]

Yes, exactly. I assume we need to test in several browsers, but yeah it works

I mean, even if it doesn't work, it could be considered an enhancement for those which do. I assumed it wasn't possible. The Classic Editor, for example, often loads to an existing tab but doesn't shift focus when saving.

Maybe we could reopen this one and repurpose it toward just that change?

[youknowriad]

So this seems to work only on Chrome for me but doesn't break other browsers, so yeah. Progressive Enhancement.

[tofumatt]

If this works only in Chrome, as you say, we should leave a comment explaining that, because otherwise this might come across as quite the bug.

Would be a good candidate for an e2e test too, especially as the behaviour is only present in Chrome ^_^

[jasmussen]

I love progressive enhancement.

But is there any way to know if this is, you know, a web standard? Is this Chrome being early in implementing a feature, or is it Chrome being Chrome? If it's a feature that should eventually trickle out to other browsers, ship it. But otherwise, probably good to generally try and avoid platform lockin.

[youknowriad]

It looks like this is standard but it's configurable by the user in the browser settings. I guess browser have different default values for these options https://developer.mozilla.org/en-US/docs/Web/API/Window/focus

[aduth]

The related specification is an interesting read as well:

The focus() method on the Window object, when invoked, must run the focusing steps with the Window object's browsing context. Additionally, if this browsing context is a top-level browsing context, user agents are encouraged to trigger some sort of notification to indicate to the user that the page is attempting to gain focus.

https://html.spec.whatwg.org/multipage/interaction.html#dom-window-focus

Effectively, this is one of those things where it's left to the browser to decide how to implement, but the intent of the change is to indicate that the tab is intended to be brought to the forefront (whether this actually occurs or some other indicator of intent like flashing, etc).

[aduth]

With #8446 being merged, I'm not sure whether to expect there's still changes shown for adding the || this.previewWindow.closed, but otherwise this looks good 👍