Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing fields #36

Open
tellyworth opened this issue Mar 2, 2020 · 1 comment
Open

Handle missing fields #36

tellyworth opened this issue Mar 2, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@tellyworth
Copy link
Contributor

Missing fields are currently handled poorly. They either result in some info being omitted on the front end (eg if the meeting title is empty), or errors (if the date or time is empty).

Some of those should probably be required fields. Others could simply use a reasonable default string such as "unnamed meeting" for the missing title.

@tellyworth tellyworth added the bug Something isn't working label Mar 2, 2020
@StevenDufresne
Copy link
Contributor

I tried to break the calendar with incomplete data. Here is how it looks:

  • With no title or team and an incomplete datetime ("2019-08-27").

Screenshot Calendar
Screenshot List

  • If there is no datetime, the date area changes to invalid date, which i think is fair.

Screenshot Calendar
Screenshot List

  • If there is no date nothing shows up in the calendar.

Conclusion
I don't think there is anything to be done here, at least from the front end. If there is no title, the layout still works and probably doesn't need more clarification. If some of the other data is missing, i think it's a good idea for it to look a tad broken to alert meeting managers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants