Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add AudioStore entity as a child of MediaStore #1738

Closed
obulat opened this issue Jun 3, 2021 · 0 comments · Fixed by WordPress/openverse-catalog#85
Closed

[Feature] Add AudioStore entity as a child of MediaStore #1738

obulat opened this issue Jun 3, 2021 · 0 comments · Fixed by WordPress/openverse-catalog#85
Assignees

Comments

@obulat
Copy link
Contributor

obulat commented Jun 3, 2021

Problem Description

To ingest audio data, the catalog needs to have the AudioStore class that would validate the data and save it to the disk.

Solution Description

After extracting the common functionality for storing any media type into MediaStore class, we can add other types of media by creating a child class that implements add_item with cleaning and validation that is specific to audio type. This means that we will need to list columns for all the metadata that we will store for audios.

Alternatives

We could add a separate AudioStore class that is not a child of MediaStore, but then we would lose the ability to reuse the common code, and would probably have a lot of code duplication.

Additional context

This is a part of the meta issue on adding audio

@obulat obulat self-assigned this Jun 3, 2021
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant