Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert the API to ASGI #2790

Closed
sarayourfriend opened this issue Aug 7, 2023 · 0 comments · Fixed by #3011
Closed

Convert the API to ASGI #2790

sarayourfriend opened this issue Aug 7, 2023 · 0 comments · Fixed by #3011
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔒 staff only Restricted to staff members
Milestone
Django ASGI

Comments

@sarayourfriend
Copy link
Collaborator

Problem

Stems from #2566. See that issue for background.

Blocked by #2789

Description

Convert the Django app to an ASGI application.

Replace the gunicorn worker from #2788 with an appropriate ASGI-capable worker. Subclass the worker to add ASGI lifecycle support and update the session-sharing implementation from #2788 to use the application lifecycle rather than worker lifecycle. Application lifecycle is more flexible and allows us to switch deployment contexts more easily.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🔒 staff only Restricted to staff members 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: api Related to the Django API labels Aug 7, 2023
@sarayourfriend sarayourfriend added this to the Django ASGI milestone Aug 7, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 7, 2023
@sarayourfriend sarayourfriend mentioned this issue Aug 10, 2023
Closed
This was referenced Sep 8, 2023
Closed
Merged
@sarayourfriend sarayourfriend removed the ⛔ status: blocked Blocked & therefore, not ready for work label Sep 13, 2023
@sarayourfriend sarayourfriend moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog Sep 18, 2023
@sarayourfriend sarayourfriend self-assigned this Sep 18, 2023
@sarayourfriend sarayourfriend moved this from 🏗 In progress to ⛔ Blocked in Openverse Backlog Oct 23, 2023
@sarayourfriend sarayourfriend moved this from ⛔ Blocked to 🏗 In progress in Openverse Backlog Nov 6, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Openverse Backlog Nov 8, 2023
@AetherUnbound AetherUnbound mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API 🔒 staff only Restricted to staff members
Projects
Openverse Backlog
Archived in project
Milestone
Django ASGI
Development

Successfully merging a pull request may close this issue.

Run the app as ASGI WordPress/openverse
1 participant
@sarayourfriend