Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use k6 release assets to build ov images #4934

Closed
dhruvkb opened this issue Sep 16, 2024 · 1 comment · Fixed by #5256
Closed

Use k6 release assets to build ov images #4934

dhruvkb opened this issue Sep 16, 2024 · 1 comment · Fixed by #5256
Assignees
@dhruvkb
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Sep 16, 2024

Description

The k6 RPM only provides packages for the x86_64 architecture. Till the aarch version is not added to the RPM (grafana/k6#2136), we should use the assets from their GitHub Releases to get the platform specific build.

Additional context

This was brought up in issue #4931, and hot-fixed by #4932 to use Rosetta emulation. This is a more elegant solution that avoids emulation. The most ideal would however be for k6 to start providing aarch builds in their RPM.
@dhruvkb dhruvkb added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations labels Sep 16, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Sep 16, 2024
@obulat
Copy link
Contributor

obulat commented Sep 16, 2024

I think most contributors will never use k6. Maybe building it should be optional?

@dhruvkb dhruvkb mentioned this issue Dec 7, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📋 Backlog to 🏗 In Progress in Openverse Backlog Dec 7, 2024
@dhruvkb dhruvkb self-assigned this Dec 9, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Avoid emulation for ov development environment WordPress/openverse
2 participants
@obulat @dhruvkb