Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook languageDirection not updated when value is set using the language switcher #4956

Open
obulat opened this issue Sep 19, 2024 · 0 comments
Open

Storybook languageDirection not updated when value is set using the language switcher #4956

obulat opened this issue Sep 19, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Sep 19, 2024

Problem

The values of Openverse i18n language and the Storybook RTL switch are not kept in sync.
Go to https://docs.openverse.org/storybook/?path=/story/components-vfooter--content and change the language to Arabic in the language switcher. Notice that the while the language of the strings changes, the page direction isn't updated.

Description

The frontend/.storybook/with-rtl.js should be updated, similar to the with-theme decorator added in Enable running the snapshot tests for both color modes

Alternatives

Keep as is since the language switcher is only available in the VFooter (internal) story.

Additional context
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Sep 19, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@obulat