Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove i18n cleanup ({} and extra #) from the i18n scripts #5149

Open
obulat opened this issue Nov 6, 2024 · 0 comments
Open

Remove i18n cleanup ({} and extra #) from the i18n scripts #5149

obulat opened this issue Nov 6, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work

Comments

@obulat
Copy link
Contributor

obulat commented Nov 6, 2024

Description

On https://translate.wordpress.org, the {} placeholders in the translation strings are replaced with ### ### placeholders. Then, we replace them back when converting to locale usable by Nuxt app.

However, some placeholders were changed to use an irregular number of #, or to have empty placeholders. We have a hot-fix in the code to replace the extra # or empty {} pairs. We also log that the invalid values were found, and link to this issue in the hot-fix.

When all of the incorrect placeholders are replaced on https://translate.wordpress.org, we can close this issue.

Additional context

Similar issue for kebab-cased keys: #2438

@obulat obulat added ⛔ status: blocked Blocked & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend labels Nov 6, 2024
@openverse-bot openverse-bot moved this to ⛔ Blocked in Openverse Backlog Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects
Status: ⛔ Blocked
Development

No branches or pull requests

1 participant