Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR review requests are not following the CODEOWNERS assignements #850

Closed
krysal opened this issue Mar 6, 2023 · 0 comments · Fixed by #851
Closed

PR review requests are not following the CODEOWNERS assignements #850

krysal opened this issue Mar 6, 2023 · 0 comments · Fixed by #851
Assignees
@krysal
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations

Comments

@krysal
Copy link
Member

krysal commented Mar 6, 2023

Description

Codeowners previous to the monorepo migration are not being followed. I suspect it's due to the last line overrides the more detailed previous ones.

openverse/.github/CODEOWNERS

Lines 1 to 4 in 1b79338

api/ @WordPress/openverse-api
ingestion_server/ @WordPress/openverse-api
frontend/ @WordPress/openverse-frontend
* @WordPress/openverse-maintainers

Reproduction

See for example: #450 (comment)
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Mar 6, 2023
@krysal krysal self-assigned this Mar 6, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Mar 6, 2023
@krysal krysal mentioned this issue Mar 6, 2023
Merged
@zackkrida zackkrida mentioned this issue Mar 6, 2023
Closed
16 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Mar 6, 2023
dhruvkb pushed a commit that referenced this issue Apr 14, 2023
@AetherUnbound
Science Museum: Handle unrecognized licenses (#850)
3dfd893 
* Science Museum: Handle unrecognized licenses

* Add present year range
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krysal krysal

Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make codeowners more specific WordPress/openverse
1 participant
@krysal