Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new "featured" view #542

Closed
1 of 3 tasks
ryelle opened this issue Nov 22, 2022 · 21 comments
Closed
1 of 3 tasks

Create a new "featured" view #542

ryelle opened this issue Nov 22, 2022 · 21 comments
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design

Comments

@ryelle
Copy link
Contributor

ryelle commented Nov 22, 2022

As mentioned in WordPress/gutenberg#44501, there should be a "featured" tag for the pattern directory. Currently we have a "featured" category, which could work for this, or we could take the opportunity to switch this over to an internal keyword (since it's not really meant to be used in the same way as the other categories), as you should be able to filter featured by category.

  • Create a new keyword term "featured", and apply the new term to patterns by wordpressdotorg
  • Add a “featured” toggle to the filter navigation (needs design)
  • Support showing only featured posts in categories, homepage, etc

Tech note— currently, we've done a lot of permalink rewriting to allow complex filtering of patterns with "pretty" urls. Adding in this filter will make it even more complex, so I would stick with a query parameter instead of trying to make the URLs pretty (ex, leave it as /patterns/categories/header/?featured=true rather than trying to inject /featured/ in there somewhere).

@jasmussen I've added this issue separately as a "needs design", but you can combine it with the design for #395 if that's easier. There are two other design/experience questions here though: Should the front page show all patterns or only featured by default? Is there a use case for showing just “community”, or should it be “All | Featured”?

@ryelle ryelle added [Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design labels Nov 22, 2022
@ryelle ryelle added this to the Update Categories & Nav milestone Nov 22, 2022
@jasmussen
Copy link

Should the front page show all patterns or only featured by default? Is there a use case for showing just “community”, or should it be “All | Featured”?

Featured from the core set sounds right to me, but I'd love thoughts from @WordPress/gutenberg-design

@jameskoster
Copy link

I agree it makes sense to give increased prominence to the featured patterns – that seems to be the whole point of that classification existing.

That said, displaying 'all' pre-filtered by 'featured' as a default configuration might be unexpected? It's a bit unusual to have filters pre-selected, normally you have to intentionally add them.

An alternative to consider would be including 'Featured' as an ordering option:

Screenshot 2022-11-23 at 12 17 31

It's a bit strange to order by a binary value (we'd need secondary ordering – chronological?), but at least this way it's not a toggle – you browse all patterns, just with featured ones appearing first.

@adamwoodnz adamwoodnz self-assigned this Nov 23, 2022
@adamwoodnz
Copy link
Contributor

@jameskoster @jasmussen thanks for your input, so is this alternative option what we want to go with? And should that then be the default ordering on page load?

@jameskoster
Copy link

Yes it would be the default.

That said it's just one idea. I'd still like to hear more thoughts from @WordPress/gutenberg-design.

@jasmussen
Copy link

That said, displaying 'all' pre-filtered by 'featured' as a default configuration might be unexpected? It's a bit unusual to have filters pre-selected, normally you have to intentionally add them.

I think it might be useful to zoom out our rewind and look at the main reason for introducing a classification between "featured" and "community", and the main reason is to have a useful classification of patterns to show in the core modal pattern explorer, this one: WordPress/gutenberg#44611

How we then filter the homepage of the pattern directory, I think we can experiment and see what ultimately works best. Is it defaulting to featured, defaulting to community, or showing "all" intermixed? If we're open to revisiting, I personally think we can pick either of these options as a starting point.

@jameskoster
Copy link

Good point. I notice we don't have an 'All' category in the plugin. Do we need one in the directory? If we remove that category, we can keep the 'Featured' one and just make it the default selection.

@jasmussen
Copy link

I think the plugin renders patterns differently than the directory, making "all" a performance challenge. Not sure 🤔

@ryelle
Copy link
Contributor Author

ryelle commented Jan 3, 2023

Quick update here: A new term, featured (59) has been added as a wporg-pattern-keyword, and can be requested via the API using http://api.wordpress.org/patterns/1.0/?locale=en_US&wp-version=6.1&pattern-keywords=59.

There are currently 126 featured patterns - all the patterns by wordpressdotorg. Right now, there is no way to see this list on the Pattern Directory website.

@richtabor
Copy link
Member

As mentioned in WordPress/gutenberg#44501, there should be a "featured" tag for the pattern directory.

If tagged "Featured" these wouldn't show up in the Block Inserter as featured patterns, right?

@ryelle
Copy link
Contributor Author

ryelle commented Mar 20, 2023

As of right now, we have 3 things going on here:

State Shows up in Block Inserter View on wp.org/patterns
internal keyword = core ✅ WP 5.8+
category = featured ✅ WP 5.9+ archive
internal keyword = featured

Conceptually anything tagged "Featured" (however we implement that) should show up in the Block Inserter.

This new featured view was never implemented on wp.org/patterns because we were waiting on a design for the new nav bar. And because it wasn't implemented there, it didn't carry over into GB or core.

@richtabor
Copy link
Member

Conceptually anything tagged "Featured" (however we implement that) should show up in the Block Inserter.

Will these always show up in the "Featured" category within the Block Inserter? Or in their respective categories?

@ryelle
Copy link
Contributor Author

ryelle commented Mar 23, 2023

Depends on the implementation (a new "Pattern Explorer" was started here WordPress/gutenberg#45237). Right now they show up in both, so this "Image and quote on a background" pattern shows up in the Featured category and the Text category.

There was some discussion about removing the Featured category (since it's not really the same as Posts, Text, etc), but AFAIK that was never picked up again.

@richtabor
Copy link
Member

What do you think about adding a top-level filter between "Curated" and "Community" patterns? "Featured" is already in use otherwise within the Pattern Inserter.

This is a simple UI update we could use to get it there (and also account for additional categories):

CleanShot 2023-03-28 at 12 04 08

@annezazu
Copy link
Collaborator

I like this approach. I think we can start with Curated and iterate as we need to as well if it doesn't land well. I weirdly like having two words starting with C too between "Curated" and "Community".

@richtabor
Copy link
Member

Should the front page show all patterns or only featured by default? Is there a use case for showing just “community”, or should it be “All | Featured”?
Featured from the core set sounds right to me, but I'd love thoughts...

Agreed. It should start with the curated set visible first.

@richtabor
Copy link
Member

What do you think about adding a top-level filter between "Curated" and "Community" patterns?

@mtias what do you think of this nomenclature?

@richtabor
Copy link
Member

We should also consider moving "Wireframe" as a third top-level category, alongside "Curated" and "Community". That way we can have Wireframe Headers, Wireframe Banners, etc.

@beafialho
Copy link
Collaborator

I like it "Curated". I'm just wondering what would show in the dropdown if we click "Curated" and "Community"?

@jasmussen
Copy link

Noting that the term "Canonical" is being suggested for themes and plugin directories. Not sure if that's an ideal term for patterns compared to "Curated", but conceptually there's some overlap.

@richtabor
Copy link
Member

I'm just wondering what would show in the dropdown if we click "Curated" and "Community"?

I was thinking just keeping it a simple select, as it is today, to be the lowest effort:

CleanShot 2023-04-27 at 12 13 37

@ryelle
Copy link
Contributor Author

ryelle commented Jun 5, 2023

Closing in favor of #580, which has a new UI & more discussion.

@ryelle ryelle closed this as not planned Won't fix, can't repro, duplicate, stale Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design
Projects
None yet
Development

No branches or pull requests

7 participants