Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Don't ship core patterns to WordPress sites in the "Featured" category #612

Closed
richtabor opened this issue Oct 20, 2023 · 3 comments · Fixed by #704
Closed

Proposal: Don't ship core patterns to WordPress sites in the "Featured" category #612

richtabor opened this issue Oct 20, 2023 · 3 comments · Fixed by #704
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Type] Discussion Proposed idea, needs input from others before actionable

Comments

@richtabor
Copy link
Member

I'm proposing that we do not ship core patterns to WordPress sites within the "Featured" category. Instead, patterns "featured" on a site should be very close to the design, look, feel, and intention of the site — not generic patterns shipped to everyone.

It's fine if these core patterns are available within specific categories, but "Featured" feels like an area where a theme should put its best work forward; and core pattern's can't be that.

Visual

I've attached a screen recording below of the Featured category in Twenty Twenty-Four. It looks great, as the theme has opted to place a number of compelling patterns in the category. But as you scroll, you'll notice the quality dropping quite drastically. The colors, look, feel, and general vibe doesnt match up with the high-quality patterns provided by the theme.

CleanShot.2023-10-20.at.10.34.10.mp4
This was referenced Oct 20, 2023
Open
Open
Open
@ryelle ryelle added [Type] Discussion Proposed idea, needs input from others before actionable [Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint labels Apr 18, 2024
@richtabor
Copy link
Member Author

How do we move this forward? I think we need to be more intentional about letting themes decide what patterns are feature, especially as we lean into the next default theme, Twenty Twenty-Five, which will surface many patterns.

I wouldn't want patterns that don't serve the purpose, style, or vibe of the theme "featured" in the Inserter.

@ryelle
Copy link
Contributor

ryelle commented Jul 17, 2024

I just replied to #587 with this:

One thing I might be able to do is removed featured from the API response sent to WP sites, if you know you will never want pattern-directory patterns in the featured category (which would include patterns loaded via slugs in theme.json). Then "featured" on wporg/patterns and "featured" on local WP sites would be fully separate things, and remote patterns would never be in featured on local sites.

Which I think may fulfill this request? The pattern directory (wporg/patterns) would still have a Featured category, and those patterns would still be sent to local WP sites, but they would not appear in the local sites' "Featured" category.

@richtabor
Copy link
Member Author

richtabor commented Jul 17, 2024 •
edited
Loading

Yes, I think that will work too. I still think we audit what patterns we're serving (#587)—but notably, none will be featured in the Inserter.

@ryelle ryelle mentioned this issue Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Component] Pattern Directory API The pattern API on WordPress.org, and/or the CPT endpoint [Type] Discussion Proposed idea, needs input from others before actionable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patterns API: Omit the "featured" category in the REST API WordPress/pattern-directory
2 participants
@ryelle @richtabor