Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow marking certain standalone plugins as experimental #1045

Closed
Tracked by #656
felixarntz opened this issue Mar 11, 2024 · 2 comments
Closed
Tracked by #656

Allow marking certain standalone plugins as experimental #1045

felixarntz opened this issue Mar 11, 2024 · 2 comments
Assignees
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@felixarntz
Copy link
Member

felixarntz commented Mar 11, 2024

Follow up to #1031: Similar to how modules can be marked as experimental, we should maintain the ability to have certain standalone plugins marked as experimental in the Performance Lab UI. This indicates that a certain plugin may be in an earlier phase and is just starting out, or it contains "riskier" features that we are for instance less confident about being used in production. While Performance Lab as a whole is sort of a Beta plugin, some of our standalone plugins are "more beta than others".

As with modules, of course any plugin can and should eventually graduate to non-experimental.

The primary reason to continue indicating and supporting the distinction between experimental and non-experimental modules, other than end user awareness, is the onboarding flow (see #1032). One of its requirements is to have a one-click button to activate all "recommended" features - which effectively means activating all "non-experimental" features.

For this issue, let's implement the following (after #1031 is done):

  • Additionally to the standalone plugins' slug and version constants hard-coded in the Performance Lab codebase, each standalone plugin should receive a boolean indicator for whether it's experimental or not.
  • Of the current 5 standalone plugins, only the auto-sizes plugin should be marked as experimental. This is mostly because there's currently no browser where its functionality is actually supported (given Chrome recently rolled back the feature).
  • The feature cards for the plugins on the PL settings screen should show a note "experimental" for those plugins which are experimental. Experimental plugins should be displayed after the non-experimental ones.
@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Mar 11, 2024
@felixarntz felixarntz added this to the PL Plugin 3.0.0 milestone Mar 11, 2024
@felixarntz
Copy link
Member Author

@joemcgill @mukeshpanchal27 LMKWYT on the description and proposed requirements.

@felixarntz
Copy link
Member Author

Fixed via #1111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant