Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core performance tests improvements #1380

Open
1 of 5 tasks
swissspidy opened this issue Jul 19, 2024 · 4 comments
Open
1 of 5 tasks

Core performance tests improvements #1380

swissspidy opened this issue Jul 19, 2024 · 4 comments
Assignees
Labels
[Issue] Overview Provides an overview of a specific project [Type] Epic A high-level project / epic that will encompass several sub-issues

Comments

@swissspidy
Copy link
Member

swissspidy commented Jul 19, 2024

Split out from #1093 to focus on solely the improvements to core/GB performance tests

  • Improve demo content
    • Needs an owner
    • Priority?
  • Add specific use cases (e.g., homepage, page with large LCP image, etc)
    • Also relevant for things like interactivity and layout stability metrics
    • Needs some fleshing out
    • Priority?
  • Better dashboard with raw data
    • Needs an owner
    • Priority?
  • Add tests for Twenty Twenty-Four
    • This was added in one of the recent refactorings. 2021, 2023, and 2024 are now tested.
  • Alignment between core and Gutenberg
    • Core relies on GitHub Actions, while GB uses a sophisticated node script for running tests.
    • Should we have 1 script for both that could also be used by the ecosystem via npm or similar? Or is a GitHub Action good enough?
@swissspidy swissspidy added [Issue] Overview Provides an overview of a specific project [Type] Epic A high-level project / epic that will encompass several sub-issues labels Jul 19, 2024
@adamsilverstein
Copy link
Member

what about running the comparison checks between trunk and the previous release (with compare-wp-performance) on a daily basis (rather than tied to a commit) and plotting the p50 differentials (rather than plotting raw numbers)?

This is the check I ran at the end of the release cycle which showed a regression so I feel like running these daily could be useful.

@swissspidy
Copy link
Member Author

Aren't the core performance tests and https://www.codevitals.run/project/wordpress supposed to help with that? Sounds like we'd be duplicating efforts.

@adamsilverstein
Copy link
Member

Aren't the core performance tests and codevitals.run/project/wordpress supposed to help with that? Sounds like we'd be duplicating efforts.

Right, That dashboard is close to what I am suggestion. If those tests already compare against the previous release, it isn't clear from the dashboard, so maybe its more of a UI issue.

Ideally, I want to run the same tests at the release stage that we have been running all along with the action.

@swissspidy
Copy link
Member Author

The core performance test workflow is callable, so we could add support for manually comparing latest vs. previous. That would kinda make https://github.com/swissspidy/compare-wp-performance obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Issue] Overview Provides an overview of a specific project [Type] Epic A high-level project / epic that will encompass several sub-issues
Projects
Status: Definition ✏️
Development

No branches or pull requests

3 participants