Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Worker Offloading: add Generator tag #1599

Closed
adamsilverstein opened this issue Oct 16, 2024 · 1 comment · Fixed by #1598
Closed

Web Worker Offloading: add Generator tag #1599

adamsilverstein opened this issue Oct 16, 2024 · 1 comment · Fixed by #1598
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin.
Milestone
web-worker-offloa...

Comments

@adamsilverstein
Copy link
Member

Feature Description

Add a generator tag so this plugin can easily be identified in the wild.

Consider adding only when the worker strategy is used, or at least ensuring we have some way of detecting that to help make measuring impact more accurate.
@adamsilverstein adamsilverstein added [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin. Good First Issue Issue particularly suitable to be worked on by new contributors labels Oct 16, 2024
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Oct 16, 2024
@adamsilverstein adamsilverstein mentioned this issue Oct 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Not Started/Backlog 📆 to Done 😃 in WP Performance 2024 Oct 16, 2024
@westonruter
Copy link
Member

Consider adding only when the worker strategy is used, or at least ensuring we have some way of detecting that to help make measuring impact more accurate.

Oh, I didn't account for this. To detect whether the functionality is being used, you can check to see if there are any scripts on the page that have the text/partytown type attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Plugin] Web Worker Offloading Issues for the Web Worker Offloading plugin.
Projects
WP Performance 2024
Status: Done 😃
Milestone
web-worker-offloading 0.1.1
Development

Successfully merging a pull request may close this issue.

Add Web Worker Offloading meta generator WordPress/performance
2 participants
@westonruter @adamsilverstein