Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend core's Autoloaded Options Site Health test if present (in WP 6.6) #1298

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Extend core's Autoloaded Options Site Health test if present (in WP 6.6) #1298

merged 3 commits into from
Jun 24, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Fixes #1274

@mukeshpanchal27 mukeshpanchal27 added [Type] Bug An existing feature is broken no milestone PRs that do not have a defined milestone for release [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only labels Jun 11, 2024
@mukeshpanchal27 mukeshpanchal27 self-assigned this Jun 11, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review June 11, 2024 10:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: joemcgill <joemcgill@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

westonruter
westonruter approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion but otherwise LGTM.

plugins/performance-lab/includes/site-health/audit-autoloaded-options/hooks.php Show resolved Hide resolved
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Jun 18, 2024
@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Jun 18, 2024
@westonruter westonruter changed the title Audit Autoloaded Options Site Health should extend Core's check if available Extend core's Autoloaded Options Site Health test if present (in WP 6.6) Jun 18, 2024
mukeshpanchal27 and others added 2 commits June 24, 2024 10:13
@mukeshpanchal27 @westonruter
Apply suggestions from code review
d872ab3 
Co-authored-by: Weston Ruter <westonruter@google.com>
@mukeshpanchal27
Add missing '@'
e4775cf
@mukeshpanchal27 mukeshpanchal27 merged commit 20f22ba into trunk Jun 24, 2024
14 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1274 branch June 24, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westonruter westonruter westonruter approved these changes

@joemcgill joemcgill Awaiting requested review from joemcgill

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Bug An existing feature is broken
Projects
WP Performance 2024
Status: Done 😃
Milestone
performance-lab 3.3.0
Development

Successfully merging this pull request may close these issues.

Audit Autoloaded Options Site Health should extend Core's check if available
2 participants
@mukeshpanchal27 @westonruter