Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce webp_uploads_get_file_mime_type helper function #1642

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Introduce webp_uploads_get_file_mime_type helper function #1642

merged 3 commits into from
Nov 11, 2024

Conversation

mukeshpanchal27
Copy link
Member

Summary

Follow-up work per #1635 (review)

@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 11, 2024
@mukeshpanchal27 mukeshpanchal27 added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature labels Nov 11, 2024
@mukeshpanchal27 mukeshpanchal27 added this to the webp-uploads n.e.x.t milestone Nov 11, 2024
@mukeshpanchal27 mukeshpanchal27 added no milestone PRs that do not have a defined milestone for release and removed no milestone PRs that do not have a defined milestone for release labels Nov 11, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review November 11, 2024 05:25
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 11, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: westonruter <westonruter@git.wordpress.org>
Co-authored-by: adamsilverstein <adamsilverstein@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 changed the title Follow-up: Introduce get_file_mime_type helper function Follow-up: Introduce webp_uploads_get_file_mime_type helper function Nov 11, 2024
westonruter
westonruter approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@westonruter westonruter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, aside from a tiny docs fix.

plugins/webp-uploads/helper.php Outdated Show resolved Hide resolved
@mukeshpanchal27 @westonruter
Apply suggestions from code review
b367d7e 
Co-authored-by: Weston Ruter <westonruter@google.com>
adamsilverstein
adamsilverstein approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@adamsilverstein adamsilverstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mukeshpanchal27 mukeshpanchal27 merged commit bbbbf2b into trunk Nov 11, 2024
14 checks passed
@mukeshpanchal27 mukeshpanchal27 deleted the fix/1635-follow-up branch November 11, 2024 16:48
@felixarntz felixarntz changed the title Follow-up: Introduce webp_uploads_get_file_mime_type helper function Introduce webp_uploads_get_file_mime_type helper function Nov 15, 2024
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label Nov 16, 2024
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Nov 18, 2024
Merged
@felixarntz felixarntz removed the skip changelog PRs that should not be mentioned in changelogs label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz left review comments

@swissspidy swissspidy swissspidy left review comments

@adamsilverstein adamsilverstein adamsilverstein approved these changes

@westonruter westonruter westonruter approved these changes

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
WP Performance 2024
Status: Done 😃
Milestone
webp-uploads 2.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@mukeshpanchal27 @westonruter @swissspidy @adamsilverstein @felixarntz