Enable all non-experimental modules on plugin activation

[kirtangajjar]

Summary

Fixes #61. Enable all non-experimental modules on plugin activation.

Fix is quiet simple so there isn't much to explain here.

[kirtangajjar]

@eclarke1 Can you please add "Needs Review" and other relevant labels as well?

[felixarntz]

@kirtangajjar This looks like a solid start. I left a few comments and suggestions for parts that need iteration.

[felixarntz]

@kirtangajjar I've added those few requested changes and with that this looks good to me. Thank you for the PR! 🎉

[mitogh]

Overall looks great, few minor comments.

[kirtangajjar]

Thank you @felixarntz @mitogh for your reviews. I have committed the suggestion made by @mitogh. Please do let me know incase this needs something else from my end :)

[felixarntz]

@kirtangajjar Sorry, see my comment in #191 (comment), I'm not sure that change actually makes sense. From what I can tell it was better the way you originally had it:

• We want to only run our logic if the option is not set.
• But now after the change suggested by @mitogh the logic is also run if the option is set to e.g. an empty array.
• The latter is problematic since it would mean we may override the user-defined configuration just because they disabled all modules, which is unexpected UX.

[felixarntz]

@kirtangajjar One thing remaining here per the above.

cc @mitogh

[kirtangajjar]

@felixarntz Fixed. Sorry didn't think that one through fully.

[felixarntz]

Thank you @kirtangajjar for the PR - awesome work! 🙌