Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .gitattributes instead of .distignore to better support ZIP creation #223

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Use .gitattributes instead of .distignore to better support ZIP creation #223

merged 5 commits into from
Mar 10, 2022

Conversation

thelovekesh
Copy link
Member

@thelovekesh thelovekesh commented Mar 9, 2022 •
edited by mitogh
Loading

Summary

Fixes #217

Relevant technical choices

  • Move .disignore to .gitattributes
  • Add README file as export-ignore in .gitattributes

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mitogh mitogh added the [Type] Enhancement A suggestion for improvement of an existing feature label Mar 9, 2022
mitogh
mitogh approved these changes Mar 9, 2022
View reviewed changes
Copy link
Member

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good and works as expected, after running the git archive command.

@mitogh mitogh added the Infrastructure Issues for the overall performance plugin infrastructure label Mar 9, 2022
@mitogh mitogh added this to the 1.0.0-beta.2 milestone Mar 9, 2022
@thelovekesh
Copy link
Member Author

Thanks, @mitogh for looking into this. I think this PR needs one more approval so can you please add reviewers?

@mitogh
Copy link
Member

mitogh commented Mar 9, 2022

That's correct @thelovekesh let's wait on someone else to take a look at this and give us some feedback before we can move forward with the merge, otherwise, feel free to mention in our next call next Tuesday (if you are unable to make it) I would make sure to mention about this.

Great work and thank you for your collaboration to the project.

felixarntz
felixarntz approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @thelovekesh - thank you for the PR!

@felixarntz felixarntz changed the title Move .distignore to .gitattributes Use .gitattributes instead of .distignore to better support ZIP creation Mar 10, 2022
@felixarntz felixarntz merged commit 47cf69c into WordPress:trunk Mar 10, 2022
@thelovekesh thelovekesh deleted the update/217-move-distignore-to-gitattributes branch March 10, 2022 02:27
@thelovekesh thelovekesh mentioned this pull request Feb 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitogh mitogh mitogh approved these changes

@felixarntz felixarntz felixarntz approved these changes

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

Introduce .gitattributes in favor of .distignore
3 participants
@thelovekesh @mitogh @felixarntz