-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub action for automated plugin deployment to wordpress.org #89
GitHub action for automated plugin deployment to wordpress.org #89
Conversation
https://github.com/actions/upload-release-asset is not maintained any more. Worth trying with https://github.com/softprops/action-gh-release#%EF%B8%8F-uploading-release-assets instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinyAhin This looks solid for a start, just two things that I think we need to improve for the first version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JustinyAhin All good now from my end, except one more tiny thing.
Co-authored-by: Eugene Manuilov <eugene.manuilov@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work here!
This will definitely make things easy for releases 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @JustinyAhin!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too.
Fixes #42.
This PR implements a GitHub action for deploying the performance plugin to W.org.
It uses 10up https://github.com/10up/action-wordpress-plugin-deploy to deploy on new releases on the repository.
The action also uses the
SVN_PASSWORD
andSVN_USERNAME
secrets (not set yet in the repository) for the credentials.Next steps:
This is usually done using this action https://github.com/actions/upload-release-asset (see https://github.com/marketplace/actions/wordpress-plugin-deploy#deploy-on-publishing-a-new-release-and-attach-a-zip-file-to-the-release).