Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action for automated plugin deployment to wordpress.org #89

Merged
merged 9 commits into from
Jan 20, 2022

Conversation

JustinyAhin
Copy link
Member

@JustinyAhin JustinyAhin commented Jan 14, 2022

Fixes #42.

This PR implements a GitHub action for deploying the performance plugin to W.org.

It uses 10up https://github.com/10up/action-wordpress-plugin-deploy to deploy on new releases on the repository.

The action also uses the SVN_PASSWORD and SVN_USERNAME secrets (not set yet in the repository) for the credentials.

Next steps:

@JustinyAhin JustinyAhin added [Type] Feature A new feature within an existing module Infrastructure Issues for the overall performance plugin infrastructure labels Jan 18, 2022
@JustinyAhin JustinyAhin added this to the 1.0.0-beta.1 milestone Jan 18, 2022
@JustinyAhin JustinyAhin added duplicate This issue or pull request already exists and removed duplicate This issue or pull request already exists labels Jan 18, 2022
@JustinyAhin
Copy link
Member Author

@JustinyAhin JustinyAhin marked this pull request as ready for review January 18, 2022 06:53
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinyAhin This looks solid for a start, just two things that I think we need to improve for the first version.

.github/workflows/deploy-dotorg.yml Show resolved Hide resolved
.github/workflows/deploy-dotorg.yml Show resolved Hide resolved
Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JustinyAhin All good now from my end, except one more tiny thing.

.distignore Outdated Show resolved Hide resolved
Co-authored-by: Eugene Manuilov <eugene.manuilov@gmail.com>
Copy link
Member

@aristath aristath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work here!
This will definitely make things easy for releases 👍

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @JustinyAhin!

Copy link
Contributor

@eugene-manuilov eugene-manuilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@felixarntz felixarntz merged commit 8cf3b18 into trunk Jan 20, 2022
@felixarntz felixarntz added the no milestone PRs that do not have a defined milestone for release label Mar 7, 2022
@felixarntz felixarntz removed this from the 1.0.0-beta.1 milestone Mar 7, 2022
@tillkruss tillkruss deleted the add/42-actions-automatic-deployment-wordpressdotorg branch March 7, 2022 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release [Type] Feature A new feature within an existing module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure GitHub action for automated plugin deployment to wordpress.org
4 participants