PHP: Pass request body as UInt8Array #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the custom file upload handler and rely on PHP body parsing to populate the $_FILES array. Instead of encoding the body bytes as a string, parsing that string, and re-encoding it as bytes, we keep the body in a binary form and pass it directly to PHP HEAP memory. Closes #997 Closes #1006 Closes #914 ## Testing instructions Confirm the CI checks pass (it will take a few iterations to get them right I'm sure :D)
adamziel
changed the title
request handler
…uestHandler tests
|
Let's rebuild PHP.wasm in a follow up PR |
bgrgicak
reviewed
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the custom file upload handler and rely on PHP body parsing to populate the $_FILES array. Instead of encoding the body bytes as a string, parsing that string, and re-encoding it as bytes, we keep the body in a binary form and pass it directly to PHP HEAP memory.
Closes #997
Closes #1006
Closes #914
Testing instructions
Confirm the CI checks pass (it will take a few iterations to get them right I'm sure :D)
cc @bgrgicak @dmsnell